tkgafs

tkgafs ·

Version 153 not display all file info on some tracks

Thats seems to fixed it, thanks again for all your efforts

Version 153 not display all file info on some tracks

Mark,

I've worked out what the issue is

the information is not displayed if the track has a comment in it

the javascript console pointed me to this

Uncaught (in promise) TypeError: parent.playlistinfo is undefinedmake_player_info make_file_info...

Version 153 not display all file info on some tracks

It seems to be specific tracks, as I said at first I though it was just flac files, but some mp3s do it as well.

I have been trying a few things out this morning, it doesnt seem to affect the choice of tracks using the personalised radio filters...

Version 153 not display all file info on some tracks

I can't reproduce this at all. You say it does it 'sometimes'. Is there a pattern? Are there specific tracks that always do it or is there something else you do that provokes it?

Version 153 not display all file info on some tracks

this is the debug info for version 1.53 which does not always display the file info

  • BACKEND INFO
    • Version 1.53
    • mysql_database [Redacted]
    • mysql_host [Redacted]
    • mysql_password [Redacted]
    • [Redac...

Version 153 not display all file info on some tracks

this is debug info for version 1.48 which display the file info

  • BACKEND INFO
    • Version 1.48
    • mysql_database [Redacted]
    • mysql_host [Redacted]
    • mysql_password [Redacted]
    • m... [Redacted]
tkgafs added topic to fatg3erman/RompR

Version 153 not display all file info on some tracks

Version 153 does not seem to be displaying all the file info for some tracks in the file info panel

I seem the same issue on both php verion 7.3 and version 8.0

at first I thought it was only flac files but some mp3s alos do not display all...

Updated to version 1.52 Personalised Radio Does Not find any tracks

will this version work on both php 7 and php 8.

I hope so :D

Updated to version 1.52 Personalised Radio Does Not find any tracks

Thanks for your quick response

everything seems to be working correctly :)

will this version work on both php 7 and php 8 ?

Updated to version 1.52 Personalised Radio Does Not find any tracks

Thanks that's probably enough info. I'm still on php 7.

Seems like PHP 8 has changed something fundamental internally but never thought to warn anybody. I've checked the docs and it's a simple fix, but not sure when I'll get around to it. Look out for ver...

Updated to version 1.52 Personalised Radio Does Not find any tracks

Sorry came back in and hadnt noticed your comment that you already had enough info

Updated to version 1.52 Personalised Radio Does Not find any tracks

At https://www.php.net/manual/en/pdostatement.fetchall.php

i found the following comment although I dont understand it !!!

There is a breaking change upgrading from PHP<7.4 to PHP 8.0. If your class extend PDOStatement, the PHP 8.0 typed prototyp...

Updated to version 1.52 Personalised Radio Does Not find any tracks

Debug option set to level 7

[root@Rompr rompr]# cat debug.log12:43:01 [310] LOG : CUSTOMRADIO : Saving Station 1960s12:43:01 [264] LOG : SAVEPREFS : Saving prefs12:43:01 [264] LOG : SAVEPREFS : radiomode = starRadios12:43:01 [264] LOG : SAVEPREFS : radiop...

Updated to version 1.52 Personalised Radio Does Not find any tracks

I'm running on Archlinux

php -v reports the folowing

PHP 8.0.2 (cli) (built: Feb 2 2021 18:26:02) ( NTS )

If I click drop downs for Genere or Tracks by artist I get nothing

I'll get a debug log later on today (busy busy ... !!)

Updated to version 1.52 Personalised Radio Does Not find any tracks

I found this in the nginx error log

[root@Rompr nginx]# cat error.log2021/02/17 10:10:01 [error] 870#870: *7 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught TypeError: PDOStatement::fetchAll(): Argument #2 must be of type int, string given...

tkgafs added topic to fatg3erman/RompR

Updated to version 1.52 Personalised Radio Does Not find any tracks

Mark,

I have just updated from version 1.48 to version 1.52

installed php-intl extension

I backed up my rompr folder, deleted everything in it, then restored my albumart and prefs folders

then unzipped version 1.52 into it

then restart...

Display Comment Tag from tracks

yes of course, I never thought of that, I suppose I'm only really using a tiny bit of Romprs capabilities

Display Comment Tag from tracks

Just thinking about this, it might make sense to change the title of the block in the Info Panel from Format Information to File or Track Information.

I didnt expect to see comments from the track there as most of the info was indeed about the file form...

Display Comment Tag from tracks

Thanks for that, I added Comment to the mpd tags and it works prfectly

tkgafs added topic to fatg3erman/RompR

Display Comment Tag from tracks

Would it be possible to display the contents of the comment tag somewhere whilst a track is playing ?

Perhaps a little track block similar to the format or collection information blocks

Filters for personalised radio

Yes that seems to have fixed issue, also noticed you have added the Album Title filter, once again thank you

Filters for personalised radio

Could the changes you have made had any afffect on updating the music collection

I added a couple of albums today and they appear correctly in the mpd tag_cache

if I search for the artist in rompr the albums appear but no artwork for them

if i...

Filters for personalised radio

Solution staring me in the face

I can say Album Artist is Fred and Artist is not Fred

this works almost perfectly, only omitting the tracks by Fred from the above album which is mainly by george

as you say adding a filter for album title would fix tha...

Filters for personalised radio

Found the debug plugins, another feature I didnt know existed !!

it reports these tagtypes

tagtype Artist, Album, AlbumArtist, Title, Track, Name, Genre, Date, Composer, Performer, Disc

I think we are definitely speaking at cross purposes, mos...

Filters for personalised radio

There's one case where this fails - in some cases I've found that MPD installations are configured to NOT return Album Artist tags. You can check this - go to the 'Debug Information' plugin in Rompr. Un...