tkgafs

tkgafs ·

Brilliant works perfectly I wonder why I didnt try that !!

thank you

Thats seems to fixed it, thanks again for all your efforts

Mark,

I've worked out what the issue is

the information is not displayed if the track has a comment in it

the javascript console pointed me to this

Uncaught (in promise) TypeError: parent.playlistinfo is undefinedmake_player_info make_file_info...

It seems to be specific tracks, as I said at first I though it was just flac files, but some mp3s do it as well.

I have been trying a few things out this morning, it doesnt seem to affect the choice of tracks using the personalised radio filters...

this is the debug info for version 1.53 which does not always display the file info

• BACKEND INFO
  • Version 1.53
  • mysql_database [Redacted]
  • mysql_host [Redacted]
  • mysql_password [Redacted]
  • [Redac...

this is debug info for version 1.48 which display the file info

• BACKEND INFO
  • Version 1.48
  • mysql_database [Redacted]
  • mysql_host [Redacted]
  • mysql_password [Redacted]
  • m... [Redacted]

Thanks for your quick response

everything seems to be working correctly :)

will this version work on both php 7 and php 8 ?

Sorry came back in and hadnt noticed your comment that you already had enough info

At https://www.php.net/manual/en/pdostatement.fetchall.php

i found the following comment although I dont understand it !!!

There is a breaking change upgrading from PHP<7.4 to PHP 8.0. If your class extend PDOStatement, the PHP 8.0 typed prototyp...

Debug option set to level 7

[root@Rompr rompr]# cat debug.log12:43:01 [310] LOG : CUSTOMRADIO : Saving Station 1960s12:43:01 [264] LOG : SAVEPREFS : Saving prefs12:43:01 [264] LOG : SAVEPREFS : radiomode = starRadios12:43:01 [264] LOG : SAVEPREFS : radiop...

I'm running on Archlinux

php -v reports the folowing

PHP 8.0.2 (cli) (built: Feb 2 2021 18:26:02) ( NTS )

If I click drop downs for Genere or Tracks by artist I get nothing

I'll get a debug log later on today (busy busy ... !!)

I found this in the nginx error log

[root@Rompr nginx]# cat error.log2021/02/17 10:10:01 [error] 870#870: *7 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught TypeError: PDOStatement::fetchAll(): Argument #2 must be of type int, string given...

yes of course, I never thought of that, I suppose I'm only really using a tiny bit of Romprs capabilities

Just thinking about this, it might make sense to change the title of the block in the Info Panel from Format Information to File or Track Information.

I didnt expect to see comments from the track there as most of the info was indeed about the file form...

Thanks for that, I added Comment to the mpd tags and it works prfectly

Yes that seems to have fixed issue, also noticed you have added the Album Title filter, once again thank you

Could the changes you have made had any afffect on updating the music collection

I added a couple of albums today and they appear correctly in the mpd tag_cache

if I search for the artist in rompr the albums appear but no artwork for them

if i...

Solution staring me in the face

I can say Album Artist is Fred and Artist is not Fred

this works almost perfectly, only omitting the tracks by Fred from the above album which is mainly by george

as you say adding a filter for album title would fix tha...

Found the debug plugins, another feature I didnt know existed !!

it reports these tagtypes

tagtype Artist, Album, AlbumArtist, Title, Track, Name, Genre, Date, Composer, Performer, Disc

I think we are definitely speaking at cross purposes, mos...

the duplicates may also have been caused by me pressing the skip button quickly to scan through the traks checking to make sure they matched what I had searched for rather than actually listening to them !!

I have to be honest I love what you have done to...

I've had a look at the Artist / Album Artist query as well and I understand what is happening not sure there is easy fix though, for a fairly esoteric use case anyway. Adding album artist index inside track table perhaps and seaching against ...

All the year stuff seems to be working correctly as far as I have tested, what would be useful is a line somewhere saying how many songs have been found that match the criteria.

After you have performed the search are the found tracks randomised,

i...

Whoops just remembered you havent done much with year and track !!

The year selection criteria still seems locked to the first track on an album, then any track on that album will be chosen